Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default visibility of tremor info logs from packages #850

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

anupdhml
Copy link
Contributor

@anupdhml anupdhml commented Mar 17, 2021

Description

Ensure info logs under the tremor namespace appear by default when tremor is run from our packages. This improves the debuggability for those tremor runs.

This behavior is aligned with the docker image's logger configuration: https://github.com/tremor-rs/tremor-runtime/blob/main/docker/logger.yaml

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

May lead to more logs being written to file by default but the effects on performance should be negligible.

mfelsche
mfelsche previously approved these changes Mar 17, 2021
Signed-off-by: Anup Dhamala <anupdhml+git@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2021

Coverage Status

Coverage remained the same at 81.657% when pulling 29bb321 on update-packaging-logger into c58b345 on main.

@anupdhml anupdhml merged commit 6ba89c2 into main Mar 17, 2021
@anupdhml anupdhml deleted the update-packaging-logger branch March 17, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants