Fix sources not setting Event::transactional
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 24, 2021 20:50
…nal(). Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
mfelsche
force-pushed
the
transactionality
branch
from
12c041e to
5e9d59b
Compare
|
|
|
I love it too. It'd be nicer if the coverage went up though 🤓
…On Wed, 24 Mar 2021, 21:55 Heinz N. Gies, ***@***.***> wrote:
[image: grafik]
<https://user-images.githubusercontent.com/119093/112381990-916d6180-8ceb-11eb-9e3e-bcf77bbbd052.png>
I love it!!! 🚀 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#870 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABX5MVL2T477MT4OE57PZ3TFJGUJANCNFSM4ZX6Y4NA>
.
|
|
All jokes aside, I don't see any code that would explain a 20% perf improvement, any idea how it improved? |
|
20mb/s in those numbers so 7.8%?
…On Wed, 24 Mar 2021, 22:14 Heinz N. Gies, ***@***.***> wrote:
All jokes aside, I don't see any code that would explain a 20% perf
improvement, any idea how it improved?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#870 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABX5MUHUKHQ7TXQPMIKYX3TFJIZ3ANCNFSM4ZX6Y4NA>
.
|
Ja too late for math, but I don't see then 7.8% either so I'm curious :D |
|
Seems to be local fluctuation due to whatever background noise through other processes on my machine. Also got a run on my branch with 255MB/s. Gonna do some more runs. |
|
Jep, all noise, consider the throughput roughly the same for this benchmark. |
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
added 3 commits
March 25, 2021 00:34
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
6 tasks
added 2 commits
March 25, 2021 13:27
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Event::transactionalorigin_urlnot containing the partition id, although the docs state it should.Related
Checklist
Performance
roughly equivalent.