Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non binding UDP sink support #901

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Add non binding UDP sink support #901

merged 2 commits into from
Apr 7, 2021

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Apr 7, 2021 •
edited
Loading

Signed-off-by: Heinz N. Gies heinz@licenser.net

Pull request

Description

Introduce the bound option to the UDP sink which can be set to false to let the sink re-acquire the connection to a target for every package

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

only sink changes

@Licenser
Add non binding UDP sink support
aaad2c1 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
mfelsche
mfelsche reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tiny questions

@Licenser
Include feedback
d1294ec 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser force-pushed the udp-allow-round-robin branch from d36f571 to d1294ec Compare April 7, 2021 13:10
@coveralls
Copy link
Collaborator

coveralls commented Apr 7, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 83.185% when pulling d1294ec on udp-allow-round-robin into c50eb02 on main.

@Licenser Licenser merged commit a706705 into main Apr 7, 2021
@Licenser Licenser deleted the udp-allow-round-robin branch April 7, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfelsche mfelsche mfelsche approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UDP offramp caching DNS IPs
3 participants
@Licenser @coveralls @mfelsche