-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop depending on dtrace provider #60
Comments
What does an 'npm install' look like (can you quote the shell session)? Crazily I don't have access to a Linux or Windows box handy right now. |
Crazily I don't have a working copy of node-gyp handy right now O_o. Will get you some logs when I get home. It's possible I was assuming the problem was dtrace-provider when really it's any native module on my systems. |
Thanks. My understanding is that node-dtrace-provider properly stubs out for non-dtrace'ing platforms and will install on Linux and Windows. So I'd first like to make sure that isn't the problem. Orthogonal to that: Make dtrace-provider a required dep was an intentional decision to not have Bunyan dtrace support silently NOT work for a user. If dtrace-provider were an "optionalDependency" then an "npm install" failure for it would be silent. "bunyan.js" will work without dtrace-provider, it just won't have the dtrace support. I'm not entirely happy with the current state because having Bunyan install depend on a binary module with a complex-enough build that it is much less reliable.... sucks. This is far from the first ticket bringing up dtrace-provider install issues hitting Bunyan. |
Yup, sorry, false alarm. |
this is still an issue when you want to install bunyan as a tool on a machine without a compiler (read all windows servers in production). The way it is now, we have to install it on a dev machine and then copy it over ... not quite ideal. |
@matthiasg I've opened issue #66 for this. I'll look into seeing if I can get dtrace-provider to not bork if the deps for binary modules aren't available. |
Sounds good ! Thanks. From: Trent Mick @matthiasghttps://github.com/matthiasg I've opened issue #66#66 for this. I'll look into seeing if I can get dtrace-provider to not bork if the deps for binary modules aren't available. — |
has this been fixed? |
nope. |
I found this to be helpful after being stuck on this problem for a bit. |
causing a bug i didn't want trentm/node-bunyan#60
causing a bug i didn't want trentm/node-bunyan#60
We were using this package great on Windows and Linux in the 0.10 timeframe; now we can't install it.
The text was updated successfully, but these errors were encountered: