-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a createLevel call, document, add tests. #300
Conversation
Let me add, I'll be happy to update the CLI tool to take mappings -- something like a '--level' arg that lets you (someone) do something like '--level "notice=35" --level "foo=46", etc. ... but only if there's a sense that this work is headed in the right direction. |
.. aaand I needed it anyway. |
code is generic, though it's impossible to trigger it for new levels (any predefined levels will work) without some changes to bunyan. The test code necessarily depends on a version of bunyan that allows new levels to be created, see trentm/node-bunyan#300
+1 |
any possibility to get this merged? would be nice to have custom levels! |
I like the usage for adding a new log level in this PR. Came looking to see if bunyan had this feature already and surprised it didn't. What else is needed to get this landed? My use case would include using this to keep all logging in one place and keep my custom stream logic in one place for forarding on the log messages to an external db. |
@trentm anything I can do here to help? I'd like to stop depending on a forked repo. I'd be happy to get this based off the head of the tree, but are there other issues you'd like to see addressed? |
Closing, rebasing, etc. |
Migrated here, for anyone following along at home: #465 |
This is a -- possibly stopgap -- solution to the need for levels beyond the default set. It's imperfect, but it's also self-contained and easy to understand.
Caveats:
.. thoughts?