Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child logger inherits 'pid' field. #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Child logger inherits 'pid' field. #539

wants to merge 1 commit into from

Conversation

serhalp
Copy link

@serhalp serhalp commented Sep 16, 2017

When a custom pid is configured on a logger, child loggers should inherit its value. Previously child loggers would get the default value from node's process.pid.

Fixes #538.

cc @bobzoller

@serhalp
Child logger inherits 'pid' field.
317acb8 
When a custom pid is configured on a logger, child loggers should inherit its value.
Previously child loggers would get the default value from node's `process.pid`.

Fixes trentm#538.
@serhalp
Copy link
Author

serhalp commented Sep 16, 2017

Here's the requested change log line. I just copied the one for the hostname fix and substituted pid:

[pull #539, issue #538] Fix LOG.child(...) to not override the pid field of the parent. A use case is when one manually sets pid to something other than process.pid. (By github.com/serhalp.)

@serhalp
Copy link
Author

serhalp commented Sep 28, 2017

bump @trentm

@serhalp serhalp mentioned this pull request Apr 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needstriage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logger.child() does not inherit 'pid' field of parent
2 participants
@serhalp @trentm