Fix footnote labels appearing out-of-order (#536) #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on a comment on #536 that shows that the footnote labels are appearing out-of-order, even though the footnote links themselves are accurate. This bug was due to the out-of-order processing of some markdown elements and the order of insertion into the
footnote_ids
list.Example:
The footnote label is inserted as each footnote is processed. However, the list is processed first, which means its footnote is processed firstthat it is given the label of
1
mistakenly.This PR fixes that by instead inserting a placeholder here, and then postprocessing the entire text top-to-bottom, which fixes the labelling.