Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten checks catalog ouptut #13

Merged

Conversation

arbulu89
Copy link
Contributor

In order to avoid doing "complex" operations in golang, as we can make them in elixir, which is more suitable for that, thie PR flattens out the checks catalog output, so we just return a list with all the checks.

The work of transforming this content in something the frontend consumes will be done by the server side.

Something like:

[
  {
    "id": "156F64",
    "name": "1.1.1",
    "group": "Corosync",
    "provider": "azure",
    ...
  },
  {
    "id": "53D035",
    "name": "1.1.1.runtime",
    "group": "Corosync",
    "provider": "azure",
    ...
  },
  {
    "id": "A1244C",
    "name": "1.1.2",
    "group": "Corosync",
    "provider": "azure",
   ...
  },
  {
    "id": "FB0E0D",
    "name": "1.1.2.runtime",
    "group": "Corosync",
    "provider": "azure",
    ...
  },
  {
    "id": "845CC9",
    ...

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit c1d313e into trento-project:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants