Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution worker pool #5

Merged

Conversation

arbulu89
Copy link
Contributor

Executions worker pool. It follows the same approach we used in the Collector data pipeline in the past.

The PR adds:

  • New /api/execute endpoint to schedule new execution events. By now, it only accepts a {"id": 1} kind of struct. We will decide the contract between the server and runner later on, but I assume an ID will come.
  • Once execution requests are coming, they are schedule. I have updated the channel to be a buffered one. This way, we can control if the channel queue is empty or not, and we can return back not possible to execute kind of answers. The channel size is not the workers number. It is only used to know if we need to reply with errored message to the POST request or not
  • Some additional test related code, as setup the test environment.

The PR doesn't implement yet the checks execution. It just have a dummy Execute function.

@arbulu89 arbulu89 added the enhancement New feature or request label Mar 18, 2022
@arbulu89 arbulu89 force-pushed the feature/add-execution-worker-pool branch from caacc30 to 27e9835 Compare March 18, 2022 14:28
@arbulu89 arbulu89 force-pushed the feature/add-execution-worker-pool branch from 27e9835 to 6b8e581 Compare March 21, 2022 08:34
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arbulu89 arbulu89 merged commit 8e0b8a5 into trento-project:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants