Updated Checks Service to hadle non selected checks scenario

trento-project · Dec 9, 2021 · 5b50b6b · 5b50b6b
1 parent bef477a
commit 5b50b6b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/web/services/checks.go b/web/services/checks.go
@@ -2,6 +2,7 @@ package services
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 
 	"github.com/mitchellh/mapstructure"
@@ -260,9 +261,15 @@ Selected checks services
 */
 
 func (c *checksService) GetSelectedChecksById(id string) (models.SelectedChecks, error) {
-	var selectedChecks models.SelectedChecks
+	selectedChecks := models.SelectedChecks{
+		ID:             "",
+		SelectedChecks: []string{},
+	}
 
 	result := c.db.Where("id", id).First(&selectedChecks)
+	if errors.Is(result.Error, gorm.ErrRecordNotFound) {
+		return selectedChecks, nil
+	}
 
 	return selectedChecks, result.Error
 }

diff --git a/web/services/checks_test.go b/web/services/checks_test.go
@@ -843,9 +843,10 @@ func (suite *ChecksServiceTestSuite) TestChecksService_GetSelectedChecksById() {
 }
 
 func (suite *ChecksServiceTestSuite) TestChecksService_GetSelectedChecksByIdError() {
-	_, err := suite.checksService.GetSelectedChecksById("other")
+	selectedChecks, err := suite.checksService.GetSelectedChecksById("other")
 
-	suite.EqualError(err, "record not found")
+	suite.NoError(err)
+	suite.EqualValues([]string{}, selectedChecks.SelectedChecks)
 }
 
 func (suite *ChecksServiceTestSuite) TestChecksService_CreateSelectedChecks() {