-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
By adding scrollbars to the <pre> codeblocks, both verticaly and horizontialy, the checks catalog should be more comfortable to use. fix trento-project#365
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, really appreciated!
Just a question, why the max-height
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MMuschner good job! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MMuschner @dottorblaster
It looks nice! Maybe it would be better to create a new class with these styles, to avoid styling all the pre
tags. Maybe by now we don't have others, but it would help to reduce issues in the future.
By the way, thank you for adding the gif!!!
@arbulu89 I actually agree but it's inside the |
@dottorblaster I didn't check that hehe |
By adding scrollbars to the codeblocks, both verticaly and
horizontialy, the checks catalog should be more comfortable to use.
fix #365