Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Added scrollbars to the codeblocks #471

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

MMuschner
Copy link
Contributor

@MMuschner MMuschner commented Nov 18, 2021

By adding scrollbars to the codeblocks, both verticaly and
horizontialy, the checks catalog should be more comfortable to use.

fix #365

By adding scrollbars to the <pre> codeblocks, both verticaly and
horizontialy, the checks catalog should be more comfortable to use.

fix trento-project#365
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, really appreciated!

Just a question, why the max-height?

@MMuschner
Copy link
Contributor Author

I experimented a bit and thought it would fit
scrollbars
.

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMuschner good job! LGTM

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MMuschner @dottorblaster
It looks nice! Maybe it would be better to create a new class with these styles, to avoid styling all the pre tags. Maybe by now we don't have others, but it would help to reduce issues in the future.

By the way, thank you for adding the gif!!!

@dottorblaster
Copy link
Contributor

@arbulu89 I actually agree but it's inside the .ha-check-remediation block, so the rule applies only in that context. Do you prefer to have a whole new class for that?

@arbulu89
Copy link
Contributor

@arbulu89 I actually agree but it's inside the .ha-check-remediation block, so the rule applies only in that context. Do you prefer to have a whole new class for that?

@dottorblaster I didn't check that hehe
No, it is fine this way. Thanks @dottorblaster

@arbulu89 arbulu89 added enhancement Improvement of existing features bug Something isn't working and removed enhancement Improvement of existing features labels Nov 18, 2021
@arbulu89 arbulu89 merged commit 729b399 into trento-project:main Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Check Catalog code blocks overflow too much and break the collapsable UX
4 participants