This repository has been archived by the owner on May 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
SAP system details page tests #743
Merged
arbulu89
merged 6 commits into
trento-project:main
from
arbulu89:tests/sap-details-page
Jan 27, 2022
Merged
SAP system details page tests #743
arbulu89
merged 6 commits into
trento-project:main
from
arbulu89:tests/sap-details-page
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
January 26, 2022 15:19
arbulu89
force-pushed
the
tests/sap-details-page
branch
2 times, most recently
from
January 27, 2022 07:47
85d04a3
to
cba5362
Compare
arbulu89
force-pushed
the
tests/sap-details-page
branch
from
January 27, 2022 07:49
cba5362
to
a278fe4
Compare
arbulu89
force-pushed
the
tests/sap-details-page
branch
from
January 27, 2022 13:28
a278fe4
to
6588899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow man, this is really nice!
I do really appreciate the effort in writing feature
files, you're doing a great job, thanks!
Helps a lot in understanding the test.
Waiting for the build to succeed 😉
test/e2e/cypress/fixtures/sap-system-details/sap_system_details.feature
Outdated
Show resolved
Hide resolved
arbulu89
force-pushed
the
tests/sap-details-page
branch
2 times, most recently
from
January 27, 2022 13:50
f0a9613
to
4559e86
Compare
arbulu89
force-pushed
the
tests/sap-details-page
branch
from
January 27, 2022 14:11
4559e86
to
55f9e0d
Compare
More things:
|
nelsonkopliku
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Ordering! We all had the same issue 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the e2e tests for the SAP system details page.
I have added a bit more of testing than the strictly required. For example, I have started playing with state changes, to see that the status badge is properly change. For that, I have added more scenario. They are sent by photofinish. Actually I thought to implement a standalone method to send specific jsons, but well, this way it works too hehe
In essence, the HANA database details page is exactly the same, but I prefer to open a new PR with that, to make the review a bit easier.