Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

SAP system details page tests #743

Merged
merged 6 commits into from
Jan 27, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jan 26, 2022

This PR implements the e2e tests for the SAP system details page.

I have added a bit more of testing than the strictly required. For example, I have started playing with state changes, to see that the status badge is properly change. For that, I have added more scenario. They are sent by photofinish. Actually I thought to implement a standalone method to send specific jsons, but well, this way it works too hehe

In essence, the HANA database details page is exactly the same, but I prefer to open a new PR with that, to make the review a bit easier.

@arbulu89 arbulu89 added the enhancement Improvement of existing features label Jan 26, 2022
@arbulu89 arbulu89 force-pushed the tests/sap-details-page branch 2 times, most recently from 85d04a3 to cba5362 Compare January 27, 2022 07:47
@arbulu89 arbulu89 marked this pull request as ready for review January 27, 2022 07:48
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow man, this is really nice!

I do really appreciate the effort in writing feature files, you're doing a great job, thanks!
Helps a lot in understanding the test.

Waiting for the build to succeed 😉

@arbulu89 arbulu89 force-pushed the tests/sap-details-page branch 2 times, most recently from f0a9613 to 4559e86 Compare January 27, 2022 13:50
@arbulu89
Copy link
Contributor Author

More things:

  • I have added an artifact-uploads steps if the e22 tests fail. It comes handy to check the video
  • Update sap_system service to return the instances ordered by instance_number. This was the reason why the tests were failing, Now, they are always coming in the same order, and ordering by instance number makes sense in my opinion

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Ordering! We all had the same issue 😄

@arbulu89 arbulu89 merged commit cbe2259 into trento-project:main Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features
Development

Successfully merging this pull request may close these issues.

2 participants