Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix 1.7 upgrade #432

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Phoenix 1.7 upgrade #432

merged 2 commits into from
Jun 24, 2024

Conversation

gagandeepb
Copy link
Contributor

Upgrading Phoenix from 1.6 to 1.7.

Some comments:

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 95.056%. remained the same
when pulling 201d48c on phoenix-1_7-upgrade
into f39a82c on main.

@gagandeepb gagandeepb marked this pull request as ready for review May 24, 2024 12:24
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

@dottorblaster
Copy link
Contributor

Great work @gagandeepb! If you want you can also have a stab at migrating from the old views to the new JSON rendering feature:

https://hexdocs.pm/phoenix/json_and_apis.html#rendering-json

Anyway, thank you so much!

@gagandeepb
Copy link
Contributor Author

@dottorblaster Thanks. I am not quite sure how the JSON rendering feature interacts with the open_api_spex schema format/serialization. I suspect/guess there might be some duplication of this Ser/De logic somewhere if both approaches were to co-exist, and this might need a deeper look/some internal conversations before proceeding.

@gagandeepb gagandeepb merged commit 2cfecea into main Jun 24, 2024
13 checks passed
@gagandeepb gagandeepb deleted the phoenix-1_7-upgrade branch June 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants