Remove new fields from v1 clusters endpoint

trento-project · Feb 20, 2024 · 0ea275d · 0ea275d
1 parent d030807
commit 0ea275d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/trento_web/views/v1/cluster_view.ex b/lib/trento_web/views/v1/cluster_view.ex
@@ -31,7 +31,7 @@ defmodule TrentoWeb.V1.ClusterView do
   defp adapt_v1(%{type: type, details: %{nodes: nodes} = details} = cluster)
        when type in [:hana_scale_up, :hana_scale_out] do
     adapted_nodes =
-      Enum.map(nodes, &Map.drop(&1, [:indexserver_actual_role, :nameserver_actual_role]))
+      Enum.map(nodes, &Map.drop(&1, [:indexserver_actual_role, :nameserver_actual_role, :status]))
 
     adapted_details =
       details

diff --git a/test/support/factory.ex b/test/support/factory.ex
@@ -461,6 +461,7 @@ defmodule Trento.Factory do
   def hana_cluster_node_factory do
     %HanaClusterNode{
       attributes: %{"attribute" => Faker.Beer.name()},
+      status: "Online",
       hana_status: "Secondary",
       virtual_ip: Faker.Internet.ip_v4_address(),
       name: Faker.StarWars.character(),
@@ -485,6 +486,7 @@ defmodule Trento.Factory do
       roles: [Enum.random(["ascs", "ers"])],
       virtual_ips: [Faker.Internet.ip_v4_address()],
       filesystems: [Faker.File.file_name()],
+      status: "Online",
       attributes: %{
         Faker.Pokemon.name() => Faker.Pokemon.name()
       },

diff --git a/test/trento_web/views/v1/cluster_view_test.exs b/test/trento_web/views/v1/cluster_view_test.exs
@@ -19,7 +19,8 @@ defmodule TrentoWeb.V1.ClusterViewTest do
         Enum.map(
           build_list(1, :hana_cluster_node, %{
             nameserver_actual_role: "master",
-            indexserver_actual_role: "master"
+            indexserver_actual_role: "master",
+            status: "Online"
           }),
           &Map.from_struct(&1)
         )
@@ -38,6 +39,7 @@ defmodule TrentoWeb.V1.ClusterViewTest do
       refute Access.get(details, :maintenance_mode)
       refute Access.get(node, :nameserver_actual_role)
       refute Access.get(node, :indexserver_actual_role)
+      refute Access.get(node, :status)
     end
   end
 end