-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract check item to individual component
- Loading branch information
Showing
5 changed files
with
138 additions
and
94 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import React from 'react'; | ||
|
|
||
| import { Disclosure, Transition } from '@headlessui/react'; | ||
|
|
||
| import ReactMarkdown from 'react-markdown'; | ||
| import remarkGfm from 'remark-gfm'; | ||
|
|
||
| const CheckItem = ({ checkID, premium = false, description, remediation }) => { | ||
| return ( | ||
| <li> | ||
| <Disclosure> | ||
| <Disclosure.Button | ||
| as="div" | ||
| className="flex justify-between w-full cursor-pointer hover:bg-gray-100" | ||
| > | ||
| <div className="check-row px-4 py-4 sm:px-6"> | ||
| <div className="flex items-center"> | ||
| <p className="px-2 inline-flex text-xs leading-5 font-semibold rounded-full bg-green-100 text-green-800"> | ||
| {checkID} | ||
| </p> | ||
| {premium > 0 && ( | ||
| <p className="px-2 inline-flex text-xs leading-5 font-semibold rounded-full bg-green-100 text-green-800"> | ||
| Premium | ||
| </p> | ||
| )} | ||
| </div> | ||
| <div className="mt-2 sm:flex sm:justify-between"> | ||
| <div className="sm:flex"> | ||
| <ReactMarkdown | ||
| className="markdown text-sm" | ||
| remarkPlugins={[remarkGfm]} | ||
| > | ||
| {description} | ||
| </ReactMarkdown> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </Disclosure.Button> | ||
| <Transition | ||
| enter="transition duration-100 ease-out" | ||
| enterFrom="transform opacity-0" | ||
| enterTo="transform opacity-100" | ||
| leave="transition duration-100 ease-out" | ||
| leaveFrom="transform opacity-100" | ||
| leaveTo="transform opacity-0" | ||
| > | ||
| <Disclosure.Panel className="check-panel border-none"> | ||
| <div className="px-8 py-4 sm:px-8"> | ||
| <div className="px-4 py-4 sm:px-4 bg-slate-100 rounded"> | ||
| <ReactMarkdown className="markdown" remarkPlugins={[remarkGfm]}> | ||
| {remediation} | ||
| </ReactMarkdown> | ||
| </div> | ||
| </div> | ||
| </Disclosure.Panel> | ||
| </Transition> | ||
| </Disclosure> | ||
| </li> | ||
| ); | ||
| }; | ||
|
|
||
| export default CheckItem; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import React from 'react'; | ||
|
|
||
| import { screen } from '@testing-library/react'; | ||
| import '@testing-library/jest-dom'; | ||
| import userEvent from '@testing-library/user-event'; | ||
|
|
||
| import { renderWithRouter } from '@lib/test-utils'; | ||
| import { catalogCheckFactory } from '@lib/test-utils/factories'; | ||
|
|
||
| import CheckItem from './CheckItem'; | ||
|
|
||
| describe('ChecksCatalog CheckItem component', () => { | ||
| it('should show check information', () => { | ||
| const check = catalogCheckFactory.build(); | ||
|
|
||
| renderWithRouter( | ||
| <CheckItem | ||
| key={check.id} | ||
| checkID={check.id} | ||
| description={check.description} | ||
| remediation={check.remediation} | ||
| /> | ||
| ); | ||
|
|
||
| expect(screen.getByText(check.id)).toBeVisible(); | ||
| expect(screen.getByText(check.description)).toBeVisible(); | ||
| }); | ||
|
|
||
| it('should show premium badge if the check is premium', () => { | ||
| const check = catalogCheckFactory.build(); | ||
|
|
||
| renderWithRouter( | ||
| <CheckItem | ||
| key={check.id} | ||
| checkID={check.id} | ||
| premium={true} | ||
| description={check.description} | ||
| remediation={check.remediation} | ||
| /> | ||
| ); | ||
|
|
||
| expect(screen.getByText('Premium')).toBeVisible(); | ||
| }); | ||
|
|
||
| it('should show check remediation when the row is clicked', () => { | ||
| const check = catalogCheckFactory.build(); | ||
|
|
||
| renderWithRouter( | ||
| <CheckItem | ||
| key={check.id} | ||
| checkID={check.id} | ||
| description={check.description} | ||
| remediation={check.remediation} | ||
| /> | ||
| ); | ||
|
|
||
| const checks = screen.getAllByRole('listitem'); | ||
| const checkDiv = checks[0].querySelector('div'); | ||
|
|
||
| expect(screen.queryByText(check.remediation)).not.toBeInTheDocument(); | ||
| userEvent.click(checkDiv); | ||
| expect(screen.getByText(check.remediation)).toBeVisible(); | ||
| userEvent.click(checkDiv); | ||
| expect(screen.queryByText(check.remediation)).not.toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters