rename functions and add space

trento-project · Aug 29, 2023 · 4f2d409 · 4f2d409
1 parent 97b2a93
commit 4f2d409
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/assets/js/components/HostDetails/HostChecksSelection.stories.jsx b/assets/js/components/HostDetails/HostChecksSelection.stories.jsx
@@ -93,12 +93,10 @@ export default {
     onUpdateCatalog: {
       description: 'Updates the catalog',
     },
-
     isSavingSelection: {
       description:
         'Whether Save Checks Selection button is enabled or disabled',
     },
-
     onSaveSelection: {
       description: 'Updates the selected checks on save',
     },

diff --git a/assets/js/components/HostDetails/HostSettingsPage.test.jsx b/assets/js/components/HostDetails/HostSettingsPage.test.jsx
@@ -91,6 +91,7 @@ describe('HostSettingsPage component', () => {
     const startExecutionButton = screen.getByText('Start Execution');
     expect(startExecutionButton).toBeDisabled();
   });
+
   it('should render HostSettingsPage with an enabled start execution button, as checks are selected', () => {
     const hosts = hostFactory.buildList(2, {
       provider: 'azure',

diff --git a/assets/js/state/actions/lastExecutions.js b/assets/js/state/actions/lastExecutions.js
@@ -1,5 +1,5 @@
 export const UPDATE_LAST_EXECUTION = 'UPDATE_LAST_EXECUTION';
-export const EXECUTION_REQUESTED = 'EXECUTION_REQUESTED';
+export const CLUSTER_EXECUTION_REQUESTED = 'CLUSTER_EXECUTION_REQUESTED';
 export const HOST_EXECUTION_REQUESTED = 'HOST_EXECUTION_REQUESTED';
 
 export const updateLastExecution = (groupID) => ({
@@ -8,7 +8,7 @@ export const updateLastExecution = (groupID) => ({
 });
 
 export const executionRequested = (clusterID, hosts, checks, navigate) => ({
-  type: EXECUTION_REQUESTED,
+  type: CLUSTER_EXECUTION_REQUESTED,
   payload: { clusterID, hosts, checks, navigate },
 });
 

diff --git a/assets/js/state/sagas/lastExecutions.js b/assets/js/state/sagas/lastExecutions.js
@@ -2,7 +2,7 @@ import { put, call, takeEvery, select } from 'redux-saga/effects';
 
 import {
   UPDATE_LAST_EXECUTION,
-  EXECUTION_REQUESTED,
+  CLUSTER_EXECUTION_REQUESTED,
   HOST_EXECUTION_REQUESTED,
 } from '@state/actions/lastExecutions';
 import { notify } from '@state/actions/notifications';
@@ -95,7 +95,7 @@ export function* watchUpdateLastExecution() {
 }
 
 export function* watchRequestExecution() {
-  yield takeEvery(EXECUTION_REQUESTED, requestExecution);
+  yield takeEvery(CLUSTER_EXECUTION_REQUESTED, requestExecution);
 }
 
 export function* watchHostRequestExecution() {

diff --git a/assets/js/state/sagas/lastExecutions.test.js b/assets/js/state/sagas/lastExecutions.test.js
@@ -25,10 +25,10 @@ const axiosMock = new MockAdapter(networkClient);
 const lastExecutionURL = (groupID) =>
   `/api/v1/checks/groups/${groupID}/executions/last`;
 
-const triggerChecksExecutionURL = (clusterId) =>
+const triggerClusterChecksExecutionURL = (clusterId) =>
   `/clusters/${clusterId}/checks/request_execution`;
 
-const hostTriggerChecksExecutionURL = (hostID) =>
+const triggerHostChecksExecutionURL = (hostID) =>
   `/hosts/${hostID}/checks/request_execution`;
 
 describe('lastExecutions saga', () => {
@@ -97,7 +97,7 @@ describe('lastExecutions saga', () => {
     const hosts = [faker.datatype.uuid(), faker.datatype.uuid()];
     const checks = [faker.color.human(), faker.color.human()];
 
-    axiosMock.onPost(triggerChecksExecutionURL(clusterID)).reply(202, {});
+    axiosMock.onPost(triggerClusterChecksExecutionURL(clusterID)).reply(202, {});
 
     const payload = { clusterID, hosts, checks };
     const dispatched = await recordSaga(
@@ -127,7 +127,7 @@ describe('lastExecutions saga', () => {
     const hosts = [faker.datatype.uuid(), faker.datatype.uuid()];
     const checks = [faker.color.human(), faker.color.human()];
 
-    axiosMock.onPost(triggerChecksExecutionURL(clusterID)).reply(400, {});
+    axiosMock.onPost(triggerClusterChecksExecutionURL(clusterID)).reply(400, {});
 
     const payload = { clusterID, hosts, checks };
     const dispatched = await recordSaga(
@@ -156,7 +156,7 @@ describe('lastExecutions saga', () => {
     const { id: hostID, hostname: hostName } = host;
     const checks = [faker.datatype.uuid(), faker.datatype.uuid()];
 
-    axiosMock.onPost(hostTriggerChecksExecutionURL(hostID)).reply(202, {});
+    axiosMock.onPost(triggerHostChecksExecutionURL(hostID)).reply(202, {});
     const payload = { checks, host };
 
     const dispatched = await recordSaga(requestHostExecution, {
@@ -176,7 +176,7 @@ describe('lastExecutions saga', () => {
     const { id: hostID, hostname: hostName } = host;
     const checks = [faker.datatype.uuid(), faker.datatype.uuid()];
 
-    axiosMock.onPost(hostTriggerChecksExecutionURL(hostID)).reply(400, {});
+    axiosMock.onPost(triggerHostChecksExecutionURL(hostID)).reply(400, {});
 
     const payload = { checks, host };
     const dispatched = await recordSaga(requestHostExecution, {