Leftover dosctring and pattern matching entries

trento-project · Mar 20, 2024 · 91f6b85 · 91f6b85
1 parent 725b169
commit 91f6b85
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/lib/trento/databases/database.ex b/lib/trento/databases/database.ex
@@ -61,10 +61,9 @@ defmodule Trento.Databases.Database do
       ),
       do: {:error, :database_not_registered}
 
-  # First time that a Database instance is registered, the SAP System starts its registration process.
+  # First time that a Database instance is registered, the Database starts its registration process.
   # Database instances are accepted when the system replication is disabled or when enabled, only if the database
   # has a primary role
-  # When an Application is discovered, the SAP System completes the registration process.
   def execute(
         %Database{database_id: nil},
         %RegisterDatabaseInstance{
@@ -161,8 +160,8 @@ defmodule Trento.Databases.Database do
     ]
   end
 
-  # When a RegisterDatabaseInstance command is received by an existing SAP System aggregate,
-  # the SAP System aggregate registers the Database instance if it is not already registered
+  # When a RegisterDatabaseInstance command is received by an existing database aggregate,
+  # the database aggregate registers the Database instance if it is not already registered
   # and updates the health when needed.
   def execute(
         %Database{instances: instances} = database,
@@ -217,7 +216,7 @@ defmodule Trento.Databases.Database do
   end
 
   # Deregister a database instance and emit a DatabaseInstanceDeregistered
-  # also potentially emit SapSystemDeregistered and DatabaseDeregistered events
+  # also potentially emit DatabaseDeregistered events
   def execute(
         %Database{database_id: database_id} = database,
         %DeregisterDatabaseInstance{

diff --git a/lib/trento/sap_systems/sap_system.ex b/lib/trento/sap_systems/sap_system.ex
@@ -561,7 +561,7 @@ defmodule Trento.SapSystems.SapSystem do
     end
   end
 
-  # Restore a SAP system when the database is registered
+  # Restore a SAP system when the all the requires instances are registered
   defp maybe_emit_sap_system_restored_event(
          %SapSystem{instances: instances},
          %RegisterApplicationInstance{
@@ -581,9 +581,6 @@ defmodule Trento.SapSystems.SapSystem do
     end
   end
 
-  # Do not restore SAP system if the database is not registered
-  defp maybe_emit_sap_system_restored_event(%SapSystem{}, %RegisterApplicationInstance{}), do: nil
-
   defp maybe_emit_sap_system_registered_or_updated_event(
          %SapSystem{sid: nil, instances: instances},
          %RegisterApplicationInstance{