Skip to content

Commit

Permalink
Addressing review feedbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
CDimonaco committed Jun 1, 2023
1 parent 9f669b3 commit ef0636d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions lib/trento/domain/sap_system/events/sap_system_tombstoned.ex
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
defmodule Trento.Domain.Events.SapSystemTombstoned do
@moduledoc """
This event is emitted when a SAP system is deregistered (decommissioned) and all the database/application instances
are also deregistered. This event shutdown the aggregate
This event is emitted when a SAP system is deregistered (decommissioned)
"""

use Trento.Event
Expand Down
2 changes: 1 addition & 1 deletion test/trento/domain/cluster/cluster_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ defmodule Trento.ClusterTest do
)
end

test "should emit the ClusterDeregistered event and ClusterTombstoned event when the last ClusterHost is deregistered and set the deregistration date into the state" do
test "should emit the ClusterDeregistered and ClusterTombstoned events when the last ClusterHost is deregistered and set the deregistration date into the state" do
cluster_id = Faker.UUID.v4()
dat = DateTime.utc_now()
host_1_added_event = build(:host_added_to_cluster_event, cluster_id: cluster_id)
Expand Down
2 changes: 1 addition & 1 deletion test/trento/domain/host/host_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ defmodule Trento.HostTest do
end

describe "deregistration" do
test "should emit the HostDeregistered and HostTombstoned event" do
test "should emit the HostDeregistered and HostTombstoned events" do
host_id = Faker.UUID.v4()
dat = DateTime.utc_now()

Expand Down
2 changes: 1 addition & 1 deletion test/trento/domain/sap_system/sap_system_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,7 @@ defmodule Trento.SapSystemTest do
end

describe "tombstoning" do
test "should tombstone a deregistered SAP system when no applications and no databases instances are left" do
test "should tombstone a deregistered SAP system when no application and no database instances are left" do
sap_system_id = UUID.uuid4()
host_id = UUID.uuid4()
secondary_database_host_id = UUID.uuid4()
Expand Down

0 comments on commit ef0636d

Please sign in to comment.