Addressing review comments about e2e cypress tests

trento-project · Jan 11, 2023 · f390b62 · f390b62
1 parent f09182c
commit f390b62
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/test/e2e/cypress/e2e/sap_systems_overview.cy.js b/test/e2e/cypress/e2e/sap_systems_overview.cy.js
@@ -212,9 +212,7 @@ context('SAP Systems Overview', () => {
 
   describe('SAP Systems Tagging', () => {
     before(() => {
-      cy.apiLogin().then(() => {
-        cy.removeTagsFromView();
-      });
+      cy.removeTagsFromView();
     });
 
     availableSAPSystems.forEach(({ sid, tag }) => {

diff --git a/test/e2e/cypress/support/commands.js b/test/e2e/cypress/support/commands.js
@@ -26,18 +26,6 @@
 
 const initializeOpenSidebar = () => cy.setCookie('sidebar-collapsed', 'false');
 
-Cypress.Commands.add('login', () => {
-  const [username, password] = [
-    Cypress.env('login_user'),
-    Cypress.env('login_password'),
-  ];
-  cy.visit('/session/new');
-  cy.get('#username').type(username);
-  cy.get('#password').type(password);
-  cy.get('[data-testid="login-submit"]').click();
-  cy.url().should('include', '/');
-});
-
 const apiLogin = () => {
   const [username, password] = [
     Cypress.env('login_user'),