Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against empty tags #305

Closed
nelsonkopliku opened this issue Apr 6, 2022 · 2 comments
Closed

Guard against empty tags #305

nelsonkopliku opened this issue Apr 6, 2022 · 2 comments

Comments

@nelsonkopliku
Copy link
Member

Currently our tagging system allows empty tags.
If I press enter on a tag input without typing any text, trento allows that tag to be created.

I would argue about the usefulness of an empty tag already here.

Then this opens the issue of not being able to delete those tags.
When I refresh the page I get the items with the empty tag pill, and when I try to delete it, the backend goes 404 because of a non-existent deletion endpoint.

Simply put

the deletion endpoint should be something like

DELETE /api/clusters/6bd7ec60-8cb1-5c6b-a892-29e1fd2f8380/tags/<the-tag-value>

When <the-tag-value> is empty, the computed enpoint being called is

DELETE /api/clusters/6bd7ec60-8cb1-5c6b-a892-29e1fd2f8380/tags/

which does not exist.

tags-bug

@nelsonkopliku
Copy link
Member Author

The backend part has been addressed here #364

@arbulu89
Copy link
Contributor

Fix for frontend: #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants