Disallow empty tags #364
Merged
Disallow empty tags #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,9 @@ defmodule Trento.Tags do | |||
|
|
|||
| alias Trento.Repo | |||
|
|
|||
| @spec create_tag(String.t(), Ecto.UUID.t(), String.t()) :: | |||
| @type taggable_resource :: :host | :cluster | :sap_system | :database | |||
| defp empty?(<<" "::binary, rest::binary>>), do: empty?(rest) | ||
| defp empty?(""), do: true | ||
| defp empty?(_string), do: false | ||
|
|
There was a problem hiding this comment.
not sure what this does? couldn't you check the length of the string?
There was a problem hiding this comment.
this guy checks for empty and blank strings 😄
nelsonkopliku
force-pushed
the
disallow_empty_tags
branch
from
a28bfac to
579578a
Compare
nelsonkopliku
force-pushed
the
disallow_empty_tags
branch
from
579578a to
729b841
Compare
nelsonkopliku
force-pushed
the
disallow_empty_tags
branch
from
729b841 to
e1a809a
Compare
nelsonkopliku
force-pushed
the
disallow_empty_tags
branch
from
d5898d0 to
c1e7c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the backend a bit more rebust when creating tags.
Frontend couterpart has not been addressed here.