Fix AboutPage test console error output #1031
Conversation
EMaksy
added
bug
| @@ -24,6 +24,8 @@ describe('AboutPage component', () => { | |||
| it('should render the about page with default values if api get request fails', async () => { | |||
| const stateValues = { flavor: 'N/A', subscriptions: 0, version: 'v0.0.0' }; | |||
| const errorMessage = { messages: "Get request '/api/about' failed" }; | |||
| jest.spyOn(console, 'error').mockImplementation(() => null); | |||
There was a problem hiding this comment.
Maybe we can have an helper called silenceErrorMessages or something, but as I write this I have to say that I'm not a big fan of silencing error messages
There was a problem hiding this comment.
Well, in this is case is a known error, so it is fine i think
There was a problem hiding this comment.
@arbulu89 if I'm not wrong this is the second time we set a similar spy, do we wanna have an helper?
There was a problem hiding this comment.
Personally I wouldn't. It is simply a one liner. But up to @EMaksy
There was a problem hiding this comment.
Then we leave it this way. LGTM
There was a problem hiding this comment.
OK fine by me, maybe when this problem reappears in the future we can discuss adding a helper!
| @@ -24,6 +24,8 @@ describe('AboutPage component', () => { | |||
| it('should render the about page with default values if api get request fails', async () => { | |||
| const stateValues = { flavor: 'N/A', subscriptions: 0, version: 'v0.0.0' }; | |||
| const errorMessage = { messages: "Get request '/api/about' failed" }; | |||
| jest.spyOn(console, 'error').mockImplementation(() => null); | |||
There was a problem hiding this comment.
Well, in this is case is a known error, so it is fine i think
Description
Every time we run the AboutPage test, there is an annoying console log error message, even when the test runs perfect.
The pr will remove the message, so the console log of the CI is not misleading.