Remove redux logic from TriggerChecksExecutionRequest component #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
enhancement
EMaksy
force-pushed
the
refactor_TriggerChecksExecutionRequest_component
branch
4 times, most recently
from
a2a829f to
1b4710a
Compare
dottorblaster
force-pushed
the
refactor_TriggerChecksExecutionRequest_component
branch
2 times, most recently
from
7b9a94d to
0b119f6
Compare
dottorblaster
force-pushed
the
refactor_TriggerChecksExecutionRequest_component
branch
from
760baeb to
efe3126
Compare
dottorblaster
approved these changes
Jan 17, 2023
dottorblaster
force-pushed
the
refactor_TriggerChecksExecutionRequest_component
branch
from
efe3126 to
d8d2dc3
Compare
EMaksy
added a commit
that referenced
this pull request
Jan 20, 2023
* Move redux outside of the TriggerChecksExecutionsRequest component Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move all redux logic from TriggerChecksExecutionRequest component to ExecutionResultsPage and ChecksResults component.
The component required parameters are passed as props now.
This is a WIP and requires of cleaning the code but here is a first idea of the upcoming refactor!
How was this tested?
Existing Test still needs to be modified for the changes