Socket Initialization on user login #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
bug
nelsonkopliku
approved these changes
Jan 13, 2023
| @@ -13,4 +13,4 @@ export const getLastExecutionByGroupID = (groupID) => | |||
| wandaClient.get(`/api/checks/groups/${groupID}/executions/last`); | |||
|
|
|||
| export const getCatalog = (env) => | |||
| wandaClient.get(`/api/checks/catalog`, { params: env }) | |||
| wandaClient.get(`/api/checks/catalog`, { params: env }); | |||
There was a problem hiding this comment.
shouldn't the linter catch this?
There was a problem hiding this comment.
It was a formatting issue, for some reason previous formatting tasks didn't catch 🤷♂️
There was a problem hiding this comment.
@CDimonaco can we investigate? are we checking the formatting?
There was a problem hiding this comment.
Yes in the CI we have the correct step, I will investigate further.
fabriziosestito
approved these changes
Jan 16, 2023
| function* watchUserLoggedIn() { | ||
| yield all([ | ||
| takeLatest('user/setUserAsLogged', initialDataFetch), | ||
| takeLatest('user/setUserAsLogged', setupSocketEvents), |
There was a problem hiding this comment.
The application will crash, it's an unrecoverable error (no sockets no frontend basically), for the initial data fetching the error handling is the same as all the api requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Socket connection needs to be initialized only after user login.
How was this tested?
Automated tests