Add remediation content #1114
Add remediation content #1114
Conversation
nelsonkopliku
requested review from
arbulu89,
dottorblaster,
fabriziosestito and
CDimonaco
nelsonkopliku
force-pushed
the
add-remediation-content
branch
from
20554dc to
1da0f4d
Compare
nelsonkopliku
force-pushed
the
add-remediation-content
branch
from
1da0f4d to
a83b97a
Compare
|
|
||
| export const getCheckRemediation = (catalog, checkID) => { | ||
| const check = findCheck(catalog, checkID); | ||
| return check?.remediation; |
There was a problem hiding this comment.
I guess having null or undefined here doesn't make much difference
There was a problem hiding this comment.
i guess so 😄 But if any preference I can change it to if whathever
There was a problem hiding this comment.
I changed to an if for consistency with getCheckDescription
| @@ -108,6 +111,13 @@ const prepareStateData = (checkExecutionStatus) => { | |||
|
|
|||
| describe('ExecutionResults', () => { | |||
| it('should render ExecutionResults with successfully fetched results', async () => { | |||
| window.IntersectionObserver = jest.fn().mockImplementation(() => ({ | |||
There was a problem hiding this comment.
What is this IntersectionObserver for?
There was a problem hiding this comment.
Headlessui dialog related need. Without it we get an error (which I don't remember now) and google helped me 😄
|
By the way @nelsonkopliku , I noticed in the gif that we are not rendering the modal title as markdown. Yet another good to have fix hehe |
|
@arbulu89 made also the dialog title a markdown. Thanks! I missed it 🚀 |
nelsonkopliku
force-pushed
the
add-remediation-content
branch
from
4734083 to
b4708ce
Compare
@EMaksy I think it is a good idea, however, since we are going to revisit this soon I'd keep the close button as part of that improvement. Makes sense? |
Description
Adds the remediation content in the dialog that opens when clicking on a check row in ExecutionResults
How was this tested?
Automatic test added