-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add premium pill to the check selection view #1115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
premium-field
branch
from
January 16, 2023 15:35
c0a2a6c
to
cb0644c
Compare
arbulu89
requested review from
dottorblaster,
nelsonkopliku,
CDimonaco,
EMaksy,
fabriziosestito,
jamie-suse and
rtorrero
January 16, 2023 15:36
CDimonaco
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dottorblaster
requested changes
Jan 16, 2023
arbulu89
force-pushed
the
premium-field
branch
from
January 17, 2023 09:19
cb0644c
to
0397aed
Compare
EMaksy
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nelsonkopliku
approved these changes
Jan 17, 2023
dottorblaster
approved these changes
Jan 17, 2023
arbulu89
force-pushed
the
premium-field
branch
from
January 17, 2023 10:36
0397aed
to
9665858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add premium flag/pill to the catalog and to the check selection view (temporary
premium
flag added to a random check to do some more manual testing)