Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add premium pill to the check selection view #1115

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Add premium pill to the check selection view #1115

merged 3 commits into from
Jan 17, 2023

Conversation

arbulu89
Copy link
Contributor

Add premium flag/pill to the catalog and to the check selection view (temporary premium flag added to a random check to do some more manual testing)

image

image

@arbulu89 arbulu89 added the enhancement New feature or request label Jan 16, 2023
@arbulu89 arbulu89 marked this pull request as ready for review January 16, 2023 15:43
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assets/js/lib/test-utils/factories/index.js Outdated Show resolved Hide resolved
assets/js/components/PremiumPill.jsx Outdated Show resolved Hide resolved
assets/js/components/PremiumPill.jsx Outdated Show resolved Hide resolved
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbulu89 arbulu89 merged commit 89cebf8 into main Jan 17, 2023
@arbulu89 arbulu89 deleted the premium-field branch January 17, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants