-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a checks provider filter for catalog_new view #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EMaksy ,
I think we need to revisit some things, as the code uses the labels to create the queries, and we need to use the provider key.
abfbceb
to
1487f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last touch!
Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks @EMaksy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add provider filter to catalog_new view * Add tests for ProviderLabel functions Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
Description
Add a filter option for the catalog_new view so incoming checks from wanda can be filtered like priviously in the catalog view
Screencast.from.2023-01-24.12-22-19.webm
How was this tested?
Added test for the ProviderLabels component functions.
Reworking the existing ChecksCatalogNew test