Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checks provider filter for catalog_new view #1136

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Jan 23, 2023

Description

Add a filter option for the catalog_new view so incoming checks from wanda can be filtered like priviously in the catalog view

Screencast.from.2023-01-24.12-22-19.webm

How was this tested?

Added test for the ProviderLabels component functions.
Reworking the existing ChecksCatalogNew test

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code labels Jan 23, 2023
@EMaksy EMaksy self-assigned this Jan 23, 2023
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EMaksy ,
I think we need to revisit some things, as the code uses the labels to create the queries, and we need to use the provider key.

assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
assets/js/components/ProviderLabel/ProviderLabel.jsx Outdated Show resolved Hide resolved
assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
@EMaksy EMaksy force-pushed the catalog_new_filter branch from abfbceb to 1487f5e Compare January 24, 2023 11:21
@EMaksy EMaksy marked this pull request as ready for review January 24, 2023 11:21
@EMaksy EMaksy requested a review from arbulu89 January 24, 2023 11:24
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last touch!

assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @EMaksy

assets/js/components/ChecksCatalog/ChecksCatalogNew.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMaksy EMaksy merged commit 354a009 into main Jan 24, 2023
@EMaksy EMaksy deleted the catalog_new_filter branch January 24, 2023 13:10
rtorrero pushed a commit to rtorrero/web that referenced this pull request Jan 25, 2023
* Add provider filter to catalog_new view

* Add tests for ProviderLabel functions

Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants