-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Check selection hint style #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code apart, LGTM @nelsonkopliku
@nelsonkopliku From a simple solution, I would say that this is good for now. Only suggestion I can think of is for Scenario 2 where you have "Start Execution Now", I would recommend that you use a primary button style (green background with white text) and remove the word now because it is repetitive (too many now words) based on the body copy above the button... I have included a suggestion below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems so far code-wise, I don't know if you wanna follow @jagabomb's indications for now
19365b7
to
3016a55
Compare
3016a55
to
7e103da
Compare
@jagabomb here's how the two scenarios look like: and @dottorblaster I had to juggle a bit with styles to not break other buttons 😅 |
Awesome, thanks for this @nelsonkopliku. This looks like a better solution to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
In the execution page if there's no last execution and there's no check selected the user gets a suggestion to select some checks first - aka a button to go to the checks selection page - which is inconsistent with the rest of the styling.
Changed so the style matches the hint to start a checks execution
Scenario 1: No checks selected and no last execution available -> hint to select checks
Scenario 1: Some checks selected and no last execution available -> hint to start execution
Extra point: adjusted icons color which was lost.
How was this tested?
Visually 😄
@abravosuse @jagabomb makes sense?