Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Check selection hint style #1202

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

nelsonkopliku
Copy link
Member

Description

In the execution page if there's no last execution and there's no check selected the user gets a suggestion to select some checks first - aka a button to go to the checks selection page - which is inconsistent with the rest of the styling.

image

Changed so the style matches the hint to start a checks execution

Scenario 1: No checks selected and no last execution available -> hint to select checks

image

Scenario 1: Some checks selected and no last execution available -> hint to start execution

image

Extra point: adjusted icons color which was lost.

How was this tested?

Visually 😄

@abravosuse @jagabomb makes sense?

Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code apart, LGTM @nelsonkopliku

@jagabomb
Copy link
Contributor

jagabomb commented Feb 20, 2023

@nelsonkopliku From a simple solution, I would say that this is good for now. Only suggestion I can think of is for Scenario 2 where you have "Start Execution Now", I would recommend that you use a primary button style (green background with white text) and remove the word now because it is repetitive (too many now words) based on the body copy above the button... I have included a suggestion below
Screenshot 2023-02-20 at 09 47 07

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems so far code-wise, I don't know if you wanna follow @jagabomb's indications for now

@nelsonkopliku nelsonkopliku force-pushed the fix-check-selection-suggestion-btn-style branch 2 times, most recently from 19365b7 to 3016a55 Compare February 21, 2023 13:20
@nelsonkopliku nelsonkopliku force-pushed the fix-check-selection-suggestion-btn-style branch from 3016a55 to 7e103da Compare February 21, 2023 13:24
@nelsonkopliku
Copy link
Member Author

@jagabomb here's how the two scenarios look like:

image

and

image
would that be enough for now?

@dottorblaster I had to juggle a bit with styles to not break other buttons 😅
We could keep track an improvement item for those buttons and their reusability.

@jagabomb
Copy link
Contributor

@jagabomb here's how the two scenarios look like:

image

and

image would that be enough for now?

@dottorblaster I had to juggle a bit with styles to not break other buttons 😅 We could keep track an improvement item for those buttons and their reusability.

Awesome, thanks for this @nelsonkopliku. This looks like a better solution to me.

Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 9e6e266 into main Feb 22, 2023
@nelsonkopliku nelsonkopliku deleted the fix-check-selection-suggestion-btn-style branch February 22, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants