Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up notifications saga #1211

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Tidy up notifications saga #1211

merged 1 commit into from
Feb 23, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Feb 22, 2023 •
edited
Loading

Description

Follows up #1206 and #1210.

@nelsonkopliku nelsonkopliku self-assigned this Feb 22, 2023
@nelsonkopliku nelsonkopliku added enhancement New feature or request chore labels Feb 22, 2023
dottorblaster
dottorblaster suggested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit too far?

assets/js/state/actions/notifications.js Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku force-pushed the cleanup-notifications-saga branch from acdc713 to c9e2e42 Compare February 22, 2023 11:29
@nelsonkopliku nelsonkopliku changed the title Cleanup notifications saga Tidy up notifications saga Feb 22, 2023
@nelsonkopliku nelsonkopliku merged commit 470c08f into main Feb 23, 2023
@nelsonkopliku nelsonkopliku deleted the cleanup-notifications-saga branch February 23, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@arbulu89 arbulu89 Awaiting requested review from arbulu89

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees

@nelsonkopliku nelsonkopliku

Labels
chore enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @fabriziosestito