Filter Component UI fixes #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagabomb
force-pushed
the
filter-ui-fixes
branch
from
4cba4bc to
26540bd
Compare
EMaksy
approved these changes
Mar 3, 2023
jagabomb
force-pushed
the
filter-ui-fixes
branch
from
26540bd to
ccc4820
Compare
dottorblaster
approved these changes
Mar 6, 2023
|
@jagabomb great :-)! When I originally "fixed" this, it broke the alignment for the cluster settings buttons and header. I quickly deployed your PR to check it and it seems it's perfect now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor inconsistencies were happening with the Filter component. Here is a list of issues:
Below are screenshots of the fixes made:
Default State
Filter Value Set State
Lastly, a hover state (background colour of light gray) has also now been added to the Filter.
How was this tested?
Visually