-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks results grouped by category #1397
Conversation
4ad95d7
to
745f48c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes required then we can merge. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nelsonkopliku good catch about the gray background. Just before i start adjusting it, @jagabomb how do you want it exactly? |
c52a931
to
935e2fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe since it's only a CSS classname we could defer the background thing to a subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just sort out the background color issue and then we're good to go.
2836651
to
2d44aa9
Compare
2d44aa9
to
83c6cfa
Compare
Description
This pull request aims to enhance the Checks Results view in order to improve the user experience by grouping checks according to categories and providing collapsible/expandable sections. The current random listing of checks in the view makes it difficult for users to quickly determine the status of a specific category's configuration. This update will bring consistency to the view, similar to the checks catalog and selection views.
Demo
How was this tested?