Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks results grouped by category #1397

Merged
merged 6 commits into from
May 15, 2023
Merged

Checks results grouped by category #1397

merged 6 commits into from
May 15, 2023

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented May 10, 2023

Description

This pull request aims to enhance the Checks Results view in order to improve the user experience by grouping checks according to categories and providing collapsible/expandable sections. The current random listing of checks in the view makes it difficult for users to quickly determine the status of a specific category's configuration. This update will bring consistency to the view, similar to the checks catalog and selection views.

  • Implemented grouping of checks in the Checks Results view based on categories.
  • Categories are now listed alphabetically for better organization.
  • Checks within each category are ordered alphabetically by description to enhance user understanding.
  • The ordering is now performed in the frontend for improved performance and consistency.

Demo

checksResultView

How was this tested?

  • Updated ExecutionResult story
  • Added unit tests for helper functions
  • Updated existing Test for ExececutionResult view

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code labels May 10, 2023
@EMaksy EMaksy self-assigned this May 10, 2023
@EMaksy EMaksy force-pushed the grouped_check_results_view branch 9 times, most recently from 4ad95d7 to 745f48c Compare May 12, 2023 15:51
@EMaksy EMaksy marked this pull request as ready for review May 12, 2023 16:03
@EMaksy EMaksy requested review from nelsonkopliku, dottorblaster, arbulu89 and jagabomb and removed request for nelsonkopliku and dottorblaster May 12, 2023 16:03
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required then we can merge. Good job!

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

Besides the comments I also noticed we might need a gray background in the accordion panel

Before
image

After
image

@EMaksy
Copy link
Member Author

EMaksy commented May 14, 2023

Hey @nelsonkopliku good catch about the gray background. Just before i start adjusting it, @jagabomb how do you want it exactly?

@EMaksy EMaksy force-pushed the grouped_check_results_view branch from c52a931 to 935e2fa Compare May 14, 2023 15:14
@EMaksy EMaksy requested a review from dottorblaster May 14, 2023 15:18
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe since it's only a CSS classname we could defer the background thing to a subsequent PR?

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just sort out the background color issue and then we're good to go.

@EMaksy EMaksy force-pushed the grouped_check_results_view branch 2 times, most recently from 2836651 to 2d44aa9 Compare May 15, 2023 08:30
@EMaksy EMaksy force-pushed the grouped_check_results_view branch from 2d44aa9 to 83c6cfa Compare May 15, 2023 08:45
@EMaksy EMaksy merged commit 2e40964 into main May 15, 2023
@EMaksy EMaksy deleted the grouped_check_results_view branch May 15, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants