Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sections in Expectations Details view #1444

Merged
merged 6 commits into from
May 26, 2023

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented May 23, 2023

Description

Currently, the structure of the view mirrors the structure of the check itself, using sections named "Expectations," "Values," and "Facts" for expect type expectations, and "Expectations" and "Facts" for expect_same type expectations.

These section names might not be immediately clear to users who are not familiar with the checks DSL.

For expect type expectations:

  • "Expectations" section will be renamed to "Evaluation Results"
  • "Values" section will be renamed to "Expected Values"
  • "Facts" section will be renamed to "Gathered Facts"

For expect_same type expectations:

  • "Expectations" section will be renamed to "Evaluation Results"
  • "Facts" section will remain unchanged as "Gathered Facts"

Demo

ExpectationsResults

ExpectationsResults.webm

ExpectedValues

ExpectedValues.webm

Gathered Facts

GatheredFacts.webm

@EMaksy EMaksy added chore javascript Pull requests that update Javascript code labels May 23, 2023
@EMaksy EMaksy self-assigned this May 23, 2023
@EMaksy EMaksy force-pushed the rename_sections_expectation_details_view branch 8 times, most recently from d55620c to 914992d Compare May 25, 2023 12:22
@EMaksy EMaksy marked this pull request as ready for review May 25, 2023 12:35
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Just a tiny change in the way we write stories.

@EMaksy EMaksy force-pushed the rename_sections_expectation_details_view branch 2 times, most recently from 1f4e349 to 2903e7d Compare May 25, 2023 13:50
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw yeah :shipit:

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EMaksy EMaksy force-pushed the rename_sections_expectation_details_view branch 2 times, most recently from 0d00bad to 2c7deb6 Compare May 26, 2023 08:59
@EMaksy EMaksy merged commit 568e5ed into main May 26, 2023
@EMaksy EMaksy deleted the rename_sections_expectation_details_view branch May 26, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants