-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sections in Expectations Details view #1444
Conversation
d55620c
to
914992d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! Just a tiny change in the way we write stories.
assets/js/components/ExecutionResults/CheckResultDetail/ExpectationsResults.stories.jsx
Outdated
Show resolved
Hide resolved
1f4e349
to
2903e7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aw yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0d00bad
to
2c7deb6
Compare
Description
Currently, the structure of the view mirrors the structure of the check itself, using sections named "Expectations," "Values," and "Facts" for expect type expectations, and "Expectations" and "Facts" for expect_same type expectations.
These section names might not be immediately clear to users who are not familiar with the checks DSL.
For expect type expectations:
For expect_same type expectations:
Demo
ExpectationsResults
ExpectationsResults.webm
ExpectedValues
ExpectedValues.webm
Gathered Facts
GatheredFacts.webm