Display cluster details by type #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
display-cluster-details-by-type
branch
from
a6abc84 to
7156d14
Compare
arbulu89
commented
May 25, 2023
| @@ -34,33 +29,35 @@ export function ClusterDetailsPage() { | |||
| return <div>Loading...</div>; | |||
| } | |||
|
|
|||
| const renderedNodes = cluster.details?.nodes?.map((node) => ({ | |||
There was a problem hiding this comment.
Moving this to the HanaClusterDetails view, as it depends on the details format, which in this case is HANA related. ASCS/ERS clusters have other details, so better to do the enrichment specifically for each type
| /> | ||
| ); | ||
| case 'ascs_ers': | ||
| return <div>ASCS/ERS</div>; |
There was a problem hiding this comment.
Simple placeholder by now. I will have the AscsErsClusterDetails component next.
I just put some text that will be in the details view to have the tests working fine
fabriziosestito
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the display of ASCS/ERS clusters. I have renamed the
ClusterDetailstoHanaClusterDetails, as later on (next PR XD), we will have aAscsErsClusterDetails.PD: Don't try to run this as it is. The backend part is in the
deregistrationbranch 😅As we have many changes in the frontend, I preferred to continue with this work in
main, but simply rebasingderegistrationto main enables everythingHow was this tested?
Tests added