Deregistration process manager retry the rollup errors from aggregates

[CDimonaco]

Description

Deregistration process manager needs to retry the rolling up errors from aggregates.

The other errors will be captured by the default implementation, so the process manager process will stop.

[arbulu89]

Nice @CDimonaco

Checking this reminded me that we might want to change the stream_roll_up_event_handler.ex and include the "deregistration` events there as well

[arbulu89]

If you want something more generic:

@error_states = [:host_rolling_up, :cluster_rolling_up, :sap_system_rolling_up]
...
def error({:error, error}, _command_or_event, %{context: context}), do
    when error in @error_states do, {:retry, context}

[fabriziosestito]

Nice @CDimonaco

Checking this reminded me that we might want to change the stream_roll_up_event_handler.ex and include the "deregistration` events there as well

@arbulu89 I don't think deregistration should cause a rollup, I think those events should be skipped. A roll-up will be triggered by the tombstone event if any.

[CDimonaco]

Nice @CDimonaco
Checking this reminded me that we might want to change the stream_roll_up_event_handler.ex and include the "deregistration` events there as well

@arbulu89 I don't think deregistration should cause a rollup, I think those events should be skipped. A roll-up will be triggered by the tombstone event if any.

Yep, this is in the other pr #1425, currently is in draft because is blocked by #1461, but you can see the logic done for clusters and hosts, only sap system are blocked

[arbulu89]

Nice @CDimonaco
Checking this reminded me that we might want to change the stream_roll_up_event_handler.ex and include the "deregistration` events there as well

@arbulu89 I don't think deregistration should cause a rollup, I think those events should be skipped. A roll-up will be triggered by the tombstone event if any.

Actually, i was thinking more if getting those events could create some pattern matching error, as we don't have them in the list. But the events handlers ignore not matched handles, so we are fine