Add text to loading state cluster details #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
documentation
EMaksy
force-pushed
the
add_text_to_loading_state_cluster_details
branch
from
6634377 to
febb632
Compare
|
@EMaksy Thanks for this. A last request is to make the text gray for, Check execution running... Other than that it looks good to me. |
EMaksy
requested review from
arbulu89,
dottorblaster,
nelsonkopliku and
jagabomb
and removed request for
arbulu89
dottorblaster
requested changes
Jun 9, 2023
EMaksy
force-pushed
the
add_text_to_loading_state_cluster_details
branch
from
53efcae to
e38dcb6
Compare
nelsonkopliku
approved these changes
Jun 9, 2023
EMaksy
force-pushed
the
add_text_to_loading_state_cluster_details
branch
from
3a498b1 to
81390ab
Compare
dottorblaster
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the CheckResultsOverview component to implement the design provided by @jagabomb. As part of this update, the Spinner component was enhanced to improve customizability and accessibility.
Demo
Before
Now:
How was this tested?
Test was added for Spinner component
Story was added for Spinner component