Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename resource_type to target_type in catalog interaction #1514

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Rename resource_type to target_type in catalog interaction #1514

merged 1 commit into from
Jun 13, 2023

Conversation

nelsonkopliku
Copy link
Member

Just a renaming of resource_type to target_type when communicating with wanda.

@nelsonkopliku nelsonkopliku self-assigned this Jun 13, 2023
EMaksy
EMaksy approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks a lot!
LGTM :D

dottorblaster
dottorblaster approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mega-LGTM

@nelsonkopliku nelsonkopliku merged commit 2a54f0f into main Jun 13, 2023
@nelsonkopliku nelsonkopliku deleted the rename-resource-type-to-target-type branch June 13, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@nelsonkopliku nelsonkopliku

Labels
chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @EMaksy