Display ENSA version frontend #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
commented
Jun 13, 2023
| httpsPort: faker.internet.port(), | ||
| instanceHostname: faker.hacker.noun(), | ||
| instanceNumber: faker.datatype.number({ min: 10, max: 99 }).toString(), | ||
| host_id: faker.datatype.uuid(), |
There was a problem hiding this comment.
I have changed this factory, as it was before, was not creating data as we store in the redux store. It was using as it comes the GenericSystemDetails view page.
Just to make it more generic, now it replicates the data coming from the web.
|
|
||
| import { GenericSystemDetails } from './GenericSystemDetails'; | ||
|
|
||
| describe('GenericSystemDetails', () => { | ||
| it('should render correctly', () => { | ||
| const title = faker.datatype.uuid(); | ||
| const sapSystem = sapSystemFactory.build(); | ||
| const sapSystem = keysToCamel(sapSystemFactory.build()); |
There was a problem hiding this comment.
The change on the factory forces me to adapt this a little.
arbulu89
force-pushed
the
display-ensa-version-frontend
branch
from
560dc67 to
d0e1ee0
Compare
arbulu89
requested review from
dottorblaster,
nelsonkopliku,
EMaksy and
rtorrero
dottorblaster
approved these changes
Jun 15, 2023
nelsonkopliku
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frontend part for ENSA replication. Next for: #1512
Basically, get and use the
ensa_versionfield. For that, we need to get with the selector the SAP systems belong to this cluster, which could be multiple in a multi-sid cluster.PD: I have changed one of the factories. We have some mess in how we use some of the selectors for sap systems, as we camel case some of the entries some few times, but only for this domain part
How was this tested?
Tested