Add Host Check Selection Domain logic #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
4 times, most recently
from
02b0e06 to
e62ec9e
Compare
nelsonkopliku
added
enhancement
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
e62ec9e to
c723433
Compare
EMaksy
reviewed
Jun 15, 2023
EMaksy
force-pushed
the
host-checks-selection-domain
branch
from
b83c54c to
33d5606
Compare
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
33d5606 to
fc32b7e
Compare
dottorblaster
requested changes
Jun 16, 2023
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
fc32b7e to
5f1e790
Compare
EMaksy
approved these changes
Jun 16, 2023
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
5f1e790 to
d16a90e
Compare
nelsonkopliku
commented
Jun 16, 2023
| %Host{host_id: nil}, | ||
| %SelectHostChecks{} | ||
| ) do | ||
| {:error, :host_not_registered} |
There was a problem hiding this comment.
I added this clause to keep the domain consistent.
However, this will be likely replaced by what has been implemented in deregistration
There was a problem hiding this comment.
Indeed, it will cause conflicts
arbulu89
approved these changes
Jun 19, 2023
| %Host{host_id: nil}, | ||
| %SelectHostChecks{} | ||
| ) do | ||
| {:error, :host_not_registered} |
There was a problem hiding this comment.
Indeed, it will cause conflicts
Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
d16a90e to
e2a161a
Compare
Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
nelsonkopliku
force-pushed
the
host-checks-selection-domain
branch
from
e2a161a to
37d424b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new command
Trento.Domain.Commands.SelectHostChecks, which allows the selection of host checks within the host aggregate. Upon execution, the command triggers the emission of theTrento.Domain.Events.HostChecksSelectedevent, leading to a change in the state.We're deferring updating cluster related command/event pair related to check selection
Trento.Domain.Commands.SelectChecks/Trento.Domain.Events.ChecksSelected.Not much for the command, but mainly for the event.
How was this tested?
Automated tests.