Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HomeHealthSummary storybook #1529

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 15, 2023

Description

Some preliminary work before working on the new HomeHealthSummary view changes.

Add storybook story to the HomeHealthSummary view.
Nothing fancy, as we have already done with other views.
I have fixed some factories on the go.

Story available at HomeHealthSummary

@arbulu89 arbulu89 added the chore label Jun 15, 2023
@arbulu89 arbulu89 force-pushed the home-health-summary-storybook branch from cab8f52 to f8864bf Compare June 15, 2023 07:42
@rtorrero rtorrero force-pushed the deregistration branch 2 times, most recently from c9bf2b8 to f0f39dd Compare June 16, 2023 12:07
@arbulu89 arbulu89 force-pushed the home-health-summary-storybook branch from 325385e to fe7d1bd Compare June 19, 2023 11:29
@arbulu89 arbulu89 changed the base branch from deregistration to main June 19, 2023 11:29
@arbulu89 arbulu89 force-pushed the home-health-summary-storybook branch from fe7d1bd to fb27044 Compare June 19, 2023 11:31

export const checksExecutionStatusEnum = () =>
faker.helpers.arrayElement(['running', 'completed', 'requested']);

const resultEnum = () =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to create its own specific resultEnum, as the values are different.
For example, the resultEnum in this case doesn't include unknown

@arbulu89 arbulu89 marked this pull request as ready for review June 19, 2023 11:43
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man nice job, thanks for taking care. Besides the one comment nothing to add --> LGTM :D

@arbulu89 arbulu89 merged commit ed5bd0c into main Jun 20, 2023
@arbulu89 arbulu89 deleted the home-health-summary-storybook branch June 20, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants