-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HomeHealthSummary storybook #1529
Conversation
cab8f52
to
f8864bf
Compare
c9bf2b8
to
f0f39dd
Compare
325385e
to
fe7d1bd
Compare
fe7d1bd
to
fb27044
Compare
|
||
export const checksExecutionStatusEnum = () => | ||
faker.helpers.arrayElement(['running', 'completed', 'requested']); | ||
|
||
const resultEnum = () => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to create its own specific resultEnum
, as the values are different.
For example, the resultEnum
in this case doesn't include unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
assets/js/components/HealthSummary/HomeHealthSummary.stories.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man nice job, thanks for taking care. Besides the one comment nothing to add --> LGTM :D
Description
Some preliminary work before working on the new
HomeHealthSummary
view changes.Add storybook story to the
HomeHealthSummary
view.Nothing fancy, as we have already done with other views.
I have fixed some factories on the go.
Story available at
HomeHealthSummary