Add ensa version sap system details #1559
Conversation
| @@ -12,6 +12,9 @@ import { | |||
| systemInstancesTableConfiguration, | |||
| } from './tableConfigs'; | |||
|
|
|||
| export const renderEnsaVersion = (ensaVersion) => | |||
There was a problem hiding this comment.
I'm not sure if the place for this function is the best one.
Suggestions?
There was a problem hiding this comment.
You can both leave it here or have a dedicated file, if we maybe get to have more and more render functions we can have something like renderers.js or something like that. For now I think we can leave it
There was a problem hiding this comment.
(if you happen to find another file name that isn't utils feels free)
There was a problem hiding this comment.
Great job!
Well, I feel guilty about the many keysToCamel you were forced to add 🙈
The initial intent about it was enabling the possibility to transform snake_case api responses/requests to camelCase objects in the code and vice-versa, but it never happened 😅
I guess we could just get rid of it, we use snake_case mixed with camelCase anyway.
Feel also free to track debt.
Done! Ticket to track this added to our refinement backlog |
Description
Add ensa version value to SAP system details view. By now, using
mainbranch the default "-" will be shown, as the backend part isderegistrationbranch. I'm sending the PR tomainto avoid yet much more conflictsStorybook stories added for SAP system and Database details.
How was this tested?
Tested and stories added