Add ensa version to sap systems overview entries #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
approved these changes
Jun 22, 2023
|
|
||
| renderWithRouter(StatefulSapSystemList); | ||
|
|
||
| const rows = screen.getByRole('table').querySelectorAll('tbody > tr'); |
There was a problem hiding this comment.
This approach is fine but you could also just do a query for 'ENSA1', 'ENSA2' and count the number of nodes that appear
There was a problem hiding this comment.
Yes, as well.
I wanted to have a more detailed test, where I check the cell position within the table together with the content
nelsonkopliku
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last episode in the
ensa versionseries!At the field to the SAP systems overview page.
The screenshot is not taken directly using
mainbranch. It has thederegistrationbranch rebased.I didn't add storybook stories this time, as the components have multiple selectors usage in different levels.
It could be fixed, but I thought that this was not the correct time.
I have played a bit using a mocked redux store in storybook, but even though it works, it is pretty horrible, as it takes away all of the options to customize the incoming arguments
How was this tested?
I have added some tests that are not related to this addition, as the view was almost untested.