-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChecksSelection component #1577
Conversation
8a90f0d
to
e5b563a
Compare
@nelsonkopliku @EMaksy I will be away for a couple weeks, so I'll leave some notes on this to make the merge and the iteration (if any) easiest as it can be.
Right now I don't have any other remark in my mind but feel free to ask! |
6e02609
to
5c19e9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job man!
Eager to see how it will be applied in the cluster and host views 🙂
assets/js/components/ChecksSelection/ChecksSelection.stories.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/ChecksSelection/ChecksSelection.stories.jsx
Outdated
Show resolved
Hide resolved
3c2d3e9
to
27e715a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nelsonkopliku
❤️
PD: Still added a comment XD, but no need of a new review, the code looks great
27e715a
to
23572b4
Compare
Just externalized the checks selection into a component of its own. Stories available 🤘