Add database deregistered event usage to redux #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
rtorrero,
dottorblaster,
CDimonaco and
jamie-suse
and removed request for
dottorblaster
CDimonaco
approved these changes
Jul 5, 2023
jamie-suse
reviewed
Jul 5, 2023
assets/js/state/databases.js
Outdated
| @@ -30,6 +30,11 @@ export const databasesListSlice = createSlice({ | |||
| appendDatabaseInstance: (state, action) => { | |||
| state.databaseInstances = [...state.databaseInstances, action.payload]; | |||
| }, | |||
| removeDatabase: (state, { payload: { id } }) => { | |||
| state.databases = state.databases.filter( | |||
| (database) => !(database.id === id) | |||
There was a problem hiding this comment.
is there a reason to use !(database.id === id) over database.id !== id here?
There was a problem hiding this comment.
nope... XD
Yes, i will change it to use your suggestion, it is more naturla
jamie-suse
reviewed
Jul 5, 2023
| expect(dispatched).toContainEqual( | ||
| removeDatabase({ | ||
| id, | ||
| sid, |
There was a problem hiding this comment.
It doesn't look like sid is necessary for removeDatabase(). A minor thing though...
There was a problem hiding this comment.
well, the payload is composed with the sid in the incoming event, so we need to put it, even though we don't use it in the reducer
jamie-suse
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listen to
datatabase_deregisteredevent, it was missing.