Fix database sid display #1639
Merged
Fix database sid display #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
commented
Jul 18, 2023
| @@ -0,0 +1,116 @@ | |||
| export default [ | |||
There was a problem hiding this comment.
The databases slice default state added, as this is how it is loaded in the initial fetch (and next updates)
dottorblaster
requested changes
Jul 18, 2023
dottorblaster
approved these changes
Jul 18, 2023
CDimonaco
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix database sid visualization in HostList view and HanaClusterDetails view.
Before this change, the database sid was only available when the SAP system was completely registered. If the database was only there, the sid was not being displayed.
This happened because the database instance list was being obtained from the SAP system list redux state instead of its own database state
How was this tested?
Tests updated