Pr environment, open/updated pr workflow #1640
Conversation
CDimonaco
force-pushed
the
pr_env_open
branch
5 times, most recently
from
7977d2e to
e113562
Compare
CDimonaco
force-pushed
the
pr_env_open
branch
2 times, most recently
from
f6baf7d to
8fed068
Compare
|
The pr is stale, waiting for ansible playbook to be updated. Missing pieces
|
CDimonaco
force-pushed
the
pr_env_open
branch
7 times, most recently
from
f165a1a to
550c962
Compare
|
After dns issues are solved, add the photofinish step, we need to make sure that the docker image is always pulled and container restarted with the newest image for the provided tag |
CDimonaco
force-pushed
the
pr_env_open
branch
3 times, most recently
from
74cd3a6 to
fb06422
Compare
| - labeled | ||
|
|
||
| env: | ||
| MANTAINERS: "[\"cdimonaco\", \"dottorblaster\", \"fabriziosestito\", \"rtorrero\", \"nelsonkopliku\", \"arbulu89\",\"jagabomb\",\"emaksy\",\"jamie-suse\"]" |
There was a problem hiding this comment.
Could we use some already predefined group instead of individual names?
We have the Developers groups for example.
Or Admins, or something like that.
Plain users don't look like the best option
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_REPOSITORY: ghcr.io/${{ github.repository_owner }}/trento-web | ||
| IMAGE_TAG: ${{ github.event.pull_request.number }}-env |
There was a problem hiding this comment.
I guess we should put PR_NUMBER here, or remove the declaration above if we are not going to use it.
|
|
||
| env: | ||
| MANTAINERS: "[\"cdimonaco\", \"dottorblaster\", \"fabriziosestito\", \"rtorrero\", \"nelsonkopliku\", \"arbulu89\",\"jagabomb\",\"emaksy\",\"jamie-suse\"]" | ||
| PR_ENV_LABEL: env |
There was a problem hiding this comment.
We would need to document this label usage
| # cache-to: type=gha,mode=max | ||
|
|
||
| create_pr_environment: | ||
| name: Create or update the pr environment |
There was a problem hiding this comment.
Maybe we should put pr as capital letters (PR) in the texts?
To highlight that it is an acronym
| needs: build-and-push-pr-image | ||
| env: | ||
| PR_BASE_URL: ${{ github.event.pull_request.number }}.prenv.trento.suse.com | ||
| PR_NUMBER: ${{ github.event.pull_request.number }} |
There was a problem hiding this comment.
Do we need to re-declare this PR_NUMBER again?
| server: | ||
| ansible_host: ${{ secrets.PR_ENV_MACHINE_IP }} | ||
| options: | | ||
| --extra-vars "web_postgres_db='${{ env.PR_NUMBER}}db' \ |
There was a problem hiding this comment.
Let's put an extra space after env.PR_NUMBER -> {{ env.PR_NUMBER }}
| force_recreate_web_container='true' \ | ||
| force_pull_images='true' \ | ||
| trento_server_url='http://${{ env.PR_BASE_URL}}'" | ||
| run-photofinish-demo-env: |
There was a problem hiding this comment.
Can we add a new line before this job?
| runs-on: ubuntu-20.04 | ||
| needs: create_pr_environment | ||
| env: | ||
| TRENTO_PR_ENV_URL: "${{ github.event.pull_request.number }}.prenv.trento.suse.com" |
There was a problem hiding this comment.
We could declare this on top of the file, to avoid re-declaring for each job
| rabbitmq_vhost='${{ env.PR_NUMBER}}' \ | ||
| rabbitmq_password='trento' \ | ||
| prometheus_url='http://localhost' \ | ||
| web_admin_password='adminpassword' \ |
There was a problem hiding this comment.
We should put this web_admin_password in our secrets just in case
CDimonaco
force-pushed
the
pr_env_open
branch
2 times, most recently
from
4983189 to
7101d8c
Compare
|
CLOSED IN FAVOR OF #1704 |
Description
This pr aims to create the github workflow for creating and updating an ephimeral pull request environment.
How was this tested?
Act locally and manual triggering