Add end-to-end deregistration tests for Host Details page #1649
Conversation
| @@ -355,4 +355,41 @@ context('Host Details', () => { | |||
| cy.get('span').find('svg').should('exist'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Deregistration', () => { | |||
| describe('"Clean up" button should be visible only for an unhealthy host', () => { | |||
There was a problem hiding this comment.
Similar tests for the visibility of the Clean up button are also already tested in the React component tests (see HostDetails.test.jsx) Do you think they are necessary in end-to-end too?
| }); | ||
|
|
||
| it('should allow to deregister a host after clean-up confirmation', () => { | ||
| cy.contains('button', 'Clean up', { timeout: 15000 }).click(); |
There was a problem hiding this comment.
The value of timeout depends on Elixir environment variable config :trento, deregistration_debounce. These timeouts are also present in the Hosts List tests for the same reason. Could we abstract this to an environment variable somehow?
There was a problem hiding this comment.
@jamie-suse I see that we use a totally different way compared with the HostList view. I think we should be consistent, and after the other is merged, follow the same logic.
@rtorrero Could you assist on this? And review as you have the best insights!
| @@ -355,4 +355,41 @@ context('Host Details', () => { | |||
| cy.get('span').find('svg').should('exist'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Deregistration', () => { | |||
| describe('"Clean up" button should be visible only for an unhealthy host', () => { | |||
| describe('"Clean up" button should be visible only for an unhealthy host', () => { | ||
| it('should not display the "Clean up" button for healthy host', () => { | ||
| cy.task('startAgentHeartbeat', [selectedHost.id]); | ||
| cy.contains('button', 'Clean up').should('not.exist'); |
There was a problem hiding this comment.
I actually preferred this one too, but when I tried it for the confirmation dialog (which also has the text Clean up) it would get only the button from the table and not the one in the modal. If you find a way for this to work in all cases, this would be preferred but otherwise I'd keep the other approach.
| cy.get('@modal').contains('button', 'Clean up').click(); | ||
|
|
||
| cy.get('@modal').should('not.exist'); | ||
| cy.url().should('eq', cy.config().baseUrl + '/hosts'); |
There was a problem hiding this comment.
We should check that the row in the host list view for this host goes away
jamie-suse
force-pushed
the
host-details-dereg-e2e
branch
from
e0ac49f to
101ff08
Compare
| it('should allow to deregister a host after clean-up confirmation', () => { | ||
| cy.contains('button', 'Clean up', { timeout: 15000 }).click(); | ||
|
|
||
| cy.get('#headlessui-portal-root').as('modal'); |
There was a problem hiding this comment.
Regarding my previous comment: I think this is how you solved the contains getting the Clean up button from the modal. If that's so, then I'm up for it. I'll create a tech debt to update the other deregistration e2e tests.
Description
Adds end-to-end deregistration tests for the Host Details page.
How was this tested?
By adding end-to-end deregistration tests for the Host Details page.