Listen to deregistration events to update home view state #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
remove-sap-system-home-deregistration
branch
from
47ac9f3 to
7556fd8
Compare
arbulu89
force-pushed
the
remove-sap-system-home-deregistration
branch
from
fcdfc09 to
30679ec
Compare
abravosuse
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Code apart, it looks good to me @arbulu89 . Thank you for the quick fix!
jamie-suse
approved these changes
Jul 20, 2023
CDimonaco
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue that Home page is not updated when a SAP system (or other resources) are deregistered.
We need to listen to these 3 events, as any of them can trigger some sort of update.
We cannot only relay in the host deregistration, as some deregistrations triggered by delta payloads would be missed.
I excluded the database deregistration, as this is always followed by a SAP system deregistration.
How is it tested?
I added a new e2e test suite. Testing this as unit test added little value. As trade-off, the e2e test suite is now yet longer, but putting this test in any other view didn't look appropriate