E2e restoration #1665
E2e restoration #1665
Conversation
There was a problem hiding this comment.
This might be overkill, but what do you think about first asserting that the host/database/cluster/SAP system does not exist, then running the scenario and asserting that it has been restored?
I guess these assertions for nonexistence will take extra time to run though. Just a thought.
| @@ -18,4 +18,19 @@ context('Databases Overview', () => { | |||
| cy.contains(hdqDatabase.sid).should('not.exist'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Restoration', () => { | |||
| const databaseToRestore = { | |||
There was a problem hiding this comment.
We have seen some recent failure on Databases and SAP systems restoration. The instances belonging to them were not recovered properly after a browser refresh.
Maybe we should consider those events.
There was a problem hiding this comment.
I've added the test and indeed it fails. Oddly enough I can't consistently reproduce the bug manually, but cypress catches it.
| id: '240f96b1-8d26-53b7-9e99-ffb0f2e735bf', | ||
| name: 'vmhdbdev01', | ||
| id: '13e8c25c-3180-5a9a-95c8-51ec38e50cfc', | ||
| tablePos: 7, |
There was a problem hiding this comment.
This looks so ugly 😅
I would rename it to tableRow anyway
There was a problem hiding this comment.
I improved it a bit by removing the dependency on the table position, should look better
rtorrero
force-pushed
the
e2e-restoration
branch
from
a5c1d61 to
37c871d
Compare
Description
This PR adds e2e tests for the restoration of hosts after they have been deregistered. It checks that the right details are restored and visible in:
Notice that to do this, we have added additional photofinish scenarios that reuse the existing discovery json messages.