Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a SAP system only when the database is present #1706

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

CDimonaco
Copy link
Member

Description

This pr fix a SAP system restore bug, we want to restore the SAP system only if the database is present.

How was this tested?

Automated tests

@CDimonaco CDimonaco added the bug Something isn't working label Aug 10, 2023
@CDimonaco CDimonaco self-assigned this Aug 10, 2023
@CDimonaco CDimonaco force-pushed the sap_system_restore_when_db_not_present branch from 41224d3 to 4ca09d9 Compare August 10, 2023 09:47
@CDimonaco CDimonaco added the env Create an ephimeral environment for the pr branch label Aug 10, 2023
@abravosuse abravosuse self-requested a review August 10, 2023 10:30
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code apart, I've tested thjs in my rolling environment with the web image from http://ghcr.io/trento-project/trento-web:1706-env and it works.

@CDimonaco CDimonaco merged commit 42eb982 into main Aug 10, 2023
@CDimonaco CDimonaco deleted the sap_system_restore_when_db_not_present branch August 10, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

3 participants