Update deregistration modal to include instances content #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
commented
Aug 30, 2023
| control: { type: 'text' }, | ||
| }, | ||
| isOpen: { | ||
| type: 'boolean', | ||
| description: 'Sets the visibility of the modal', | ||
| control: false, | ||
| }, | ||
| onCleanUp: { |
There was a problem hiding this comment.
Removing onCleanUp and onClose. Otherwise the actions are not really executed, as storybook catches them.
The other option is just to simplify the story to get read of the custom button behaviour and let storybook catch the actions
arbulu89
force-pushed
the
instance-deregistration-modal
branch
from
dec992c to
7d38ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
DeregistrationModalcomponent to include content for application and database instances.The default content continues being the host deregistration one.
Check
DeregistrationModalstorybook to see the new modals.How was this tested?
Tested and storybook updated